fix: release the canvas backing store on unmount - #443
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The implementation directly addresses the leak and includes focused regression coverage.
Pull request overview
Releases canvas backing-store memory during unmount, addressing Safari memory growth.
Changes:
- Tracks the current canvas with a stable ref and zeroes its dimensions on teardown.
- Cancels pending intersection retest timers.
- Adds regression tests for canvas cleanup and timer cancellation.
File summaries
| File | Description |
|---|---|
src/hooks/useRive.tsx |
Releases canvas memory and clears teardown timers. |
test/useRive.test.tsx |
Tests backing-store release and ref stability. |
test/useRiveIntersection.test.tsx |
Tests intersection timer cancellation. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should address #440 to properly set width/height of an unmounting canvas to 0.